企业微信和第三方平台功能增强#2307
Closed
cqyisbug wants to merge 9 commits intobinarywang:developfrom
Closed
Conversation
cqyisbug
commented
Sep 8, 2021
- 添加企业微信 Spring boot starter,添加基础依赖 spring boot starter
- 添加第三方开放平台部分云函数接口
- 重构企业微信 WxCpMessage,支持最新企业微信文档的多种消息发送模式
- 优化XStream相关工具类
2. 添加第三方开放平台部分云函数接口 3. 重构企业微信 WxCpMessage,支持最新企业微信文档的多种消息发送模式 4. 优化XStream相关工具类
|
觉得挺不错,就是一次性提交太多,没法看。 最好能按功能拆分commit, 一个commit实现一个主要功能。 |
Author
哎,本来没想着pr,自己用用算了,毕竟改的挺多,有些东西是按照自己想法来的。最近发现合并主仓库代码越来越麻烦,就想着pr一下 |
huayanYu
reviewed
Sep 8, 2021
huayanYu
left a comment
There was a problem hiding this comment.
觉得挺不错,就是一次性提交太多,没法看。
最好能按功能拆分commit, 一个commit实现一个主要功能。
1。 基础模块架子。
2.。 功能1
3 功能2哎,本来没想着pr,自己用用算了,毕竟改的挺多,有些东西是按照自己想法来的。最近发现合并主仓库代码越来越麻烦,就想着pr一下
恩,参与开源肯定费事麻烦。 不过就靠大家参与才能更好啊。
| public boolean ignoreMatch() { | ||
| return false; | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
加抽象类是不让使用者迷惑,继承之后只要修改对应的条件函数就行,其他的函数都可以忽略,没有这个抽象类,直接实现接口,实现类里面会有很多的不想干方法
Owner
|
非常谢谢你的代码,实在是太多,无法一一查看。 |
binarywang
reviewed
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.