Skip to content

feat(cp/oa): add phonenumber field to ContentValue for PhoneNumber control #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binarywang merged 1 commit into from
May 1, 2026
Merged

feat(cp/oa): add phonenumber field to ContentValue for PhoneNumber control #3973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions weixin-java-cp/src/main/java/me/chanjar/weixin/cp/bean/oa/applydata/ContentValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,20 @@ public class ContentValue implements Serializable {
@SerializedName("bank_account")
private BankAccount bankAccount;

@SerializedName("phonenumber")
private PhoneNumber phonenumber;

/**
Comment on lines +65 to +67
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

字段名 phonenumber 不符合本类其他字段的驼峰命名风格（如 newNumber、bankAccount 等），会导致生成的 getter/setter 为 getPhonenumber/setPhonenumber，对 Java 调用方不够一致。建议将字段改为 phoneNumber（保持 @SerializedName("phonenumber") 不变）；如确实需要兼容 getPhonenumber() 命名，可额外提供一个委托方法作为别名。

Suggested change
private PhoneNumber phonenumber;
/**
private PhoneNumber phoneNumber;
/**
* 兼容历史命名的 getter。
*
* @return 手机号控件值
*/
public PhoneNumber getPhonenumber() {
return this.phoneNumber;
}
/**
* 兼容历史命名的 setter。
*
* @param phonenumber 手机号控件值
* @return 当前对象
*/
public ContentValue setPhonenumber(PhoneNumber phonenumber) {
this.phoneNumber = phonenumber;
return this;
}
/**

Copilot uses AI. Check for mistakes.
* Phone number control value: {@code value.phonenumber = { area, number }}.
* e.g. area="+62", number="87827717730"
*/
@Data
public static class PhoneNumber implements Serializable {
private static final long serialVersionUID = 1L;
private String area;
private String number;
}
Comment on lines +64 to +76
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本 PR 为 ContentValue 新增了 phonenumber 反序列化能力，但当前改动未包含对应的单元测试。仓库中已有对 OA JSON 序列化/反序列化的 TestNG 用例（例如 WxCpOaServiceImplTest 中的 testApprovalDetailSumMoney），建议补充一个最小化测试：将 { "phonenumber": { "area": "+62", "number": "87827717730" } } 反序列化为 ContentValue 并断言 getPhoneNumber()/getPhonenumber() 的 number 字段正确，避免后续回归。

Copilot uses AI. Check for mistakes.

/**
* The type Date.
*/
Expand Down