[pull] master from jenkinsci:master #1302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r readability in Functions (#20000) * Fix Javadoc grammar in InstanceIdentityProvider; use toString() for readability in Functions.toEmailSafeString - Correct “will must be currently valid” -> “must be currently valid” in Javadoc (two occurrences) - Prefer buf.toString() over String.valueOf(buf) for clarity; no behavior change Signed-off-by: shbhmexe <[email protected]> * ci: retrigger checks Signed-off-by: shbhmexe <[email protected]> * tests: make ViewTest.privateView resilient to new dashboard tabs - Detect the active view using either classic tabBar markup or the new app-build-tabs buttons. - Avoid brittle XPath that breaks when NewDashboardPageUserExperimentalFlag is enabled. No production code changes. Signed-off-by: shbhmexe <[email protected]> * Reverted the changes introduced in the most recent commit on this branch. Replaces support for both classic and new dashboard tab selectors with a single XPath targeting the classic tab bar. This streamlines the test by removing conditional logic for different UI layouts. * Remove unrelated change * Fix indentation in ViewTest privateViewsPage section Corrected indentation for the 'viewLabel' assignment in the ViewTest to improve code readability and maintain consistency. --------- Signed-off-by: shbhmexe <[email protected]> Co-authored-by: Mark Waite <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )