fix(version): make it work with connectors 8.9#171
Open
mathias-vandaele wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates both the OData and RFC SAP Connector modules to use the latest dependencies, improves annotation usage, and streamlines the Maven build configuration. The changes focus on updating parent and dependency versions, switching to improved annotation packages, cleaning up unnecessary dependencies, and centralizing formatting plugins in the parent POM for consistency across modules.
Dependency and Version Updates:
Updated the parent POM and all module POMs (
pom.xml,odata-connector/pom.xml,rfc-connector/pom.xml) to use newer versions of Camunda, SAP Cloud SDK, and Spring Boot dependencies. This ensures compatibility and access to recent features and fixes. [1] [2] [3] [4]Updated the annotation imports in
ODataConnectorRequest.java,ODataRequestDetails.java, andRFCConnectorRequest.javato useFeelModefromgenerator.java.annotationinstead of the deprecated DSL location. This modernizes the code and aligns with current best practices. [1] [2] [3] [4] [5] [6] [7] [8]Build and Dependency Management Improvements:
Replaced
element-template-generator-corewithelement-template-generator-annotationsand addedconnector-object-mapperas a provided dependency in both connector modules, supporting improved code generation and object mapping. [1] [2]Removed unnecessary dependencies and exclusions, such as
slf4j-jdk14,logback-classic, and redundant exclusions for logging libraries, to simplify the dependency tree and avoid conflicts. [1] [2] [3] [4] [5] [6]Maven Build and Formatting Plugin Centralization:
Centralized the Spotless formatting and validation plugin configuration in the parent
pom.xmland removed redundant plugin and profile definitions from the module POMs. This ensures consistent code formatting and validation across all modules and reduces duplication. [1] [2] [3] [4]Updated plugin versions and configurations for
spring-boot-maven-pluginand removed unnecessarymaven-jar-pluginconfiguration in the RFC connector. [1] [2]These changes collectively modernize the project, reduce maintenance overhead, and improve build reliability.