Skip to content

fix(pinning): pin CAP bookshop dev deps after Mini Shai Hulud incident#172

Open
mathias-vandaele wants to merge 1 commit into
mainfrom
mini-shai-hulud-fix
Open

fix(pinning): pin CAP bookshop dev deps after Mini Shai Hulud incident#172
mathias-vandaele wants to merge 1 commit into
mainfrom
mini-shai-hulud-fix

Conversation

@mathias-vandaele
Copy link
Copy Markdown

@mathias-vandaele mathias-vandaele commented May 5, 2026

This pull request focuses on supply-chain security hardening for the odata-connector/cap-bookshop test backend, in response to the SAP "Mini Shai-Hulud" npm incident. The main changes include pinning dependencies to specific versions, updating installation practices to prevent execution of potentially unsafe scripts, and documenting the security context and mitigations.

Dependency and supply-chain security hardening:

  • Pinned @sap/cds to version 8.1.1 and @cap-js/sqlite to version 1.7.6 in both package.json and package-lock.json to avoid vulnerable or unexpected package updates. [1] [2]
  • Updated the Dockerfile to use npm ci --ignore-scripts for reproducible installs and to prevent execution of package lifecycle scripts, reducing the risk from compromised dependencies.

Documentation and transparency:

  • Added a detailed "Security scope" section to readme.md, explaining the test-only usage, supply-chain review, and specific mitigations taken against the npm incident.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 5, 2026

CLA assistant check
All committers have signed the CLA.

@mathias-vandaele mathias-vandaele force-pushed the mini-shai-hulud-fix branch 3 times, most recently from caaec59 to 1eed457 Compare May 5, 2026 07:03
@mathias-vandaele
Copy link
Copy Markdown
Author

@vobu I believe the credentials are not good anymore, I faced this issue locally as well 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants