fix(pinning): pin CAP bookshop dev deps after Mini Shai Hulud incident#172
Open
mathias-vandaele wants to merge 1 commit into
Open
fix(pinning): pin CAP bookshop dev deps after Mini Shai Hulud incident#172mathias-vandaele wants to merge 1 commit into
mathias-vandaele wants to merge 1 commit into
Conversation
caaec59 to
1eed457
Compare
1eed457 to
8b2eb94
Compare
Author
|
@vobu I believe the credentials are not good anymore, I faced this issue locally as well 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on supply-chain security hardening for the
odata-connector/cap-bookshoptest backend, in response to the SAP "Mini Shai-Hulud" npm incident. The main changes include pinning dependencies to specific versions, updating installation practices to prevent execution of potentially unsafe scripts, and documenting the security context and mitigations.Dependency and supply-chain security hardening:
@sap/cdsto version8.1.1and@cap-js/sqliteto version1.7.6in bothpackage.jsonandpackage-lock.jsonto avoid vulnerable or unexpected package updates. [1] [2]npm ci --ignore-scriptsfor reproducible installs and to prevent execution of package lifecycle scripts, reducing the risk from compromised dependencies.Documentation and transparency:
readme.md, explaining the test-only usage, supply-chain review, and specific mitigations taken against the npm incident.