-
Notifications
You must be signed in to change notification settings - Fork 2
chore: Update CODEOWNERS for pnpm/uv migration #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: Update CODEOWNERS for pnpm/uv migration
- Loading branch information
commit a2aa5e05ba7a56b4a0f0498cc531e88a71750e42
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| * @cloudquery/cloudquery-framework | ||
|
|
||
| package-lock.json | ||
| pnpm-lock.yaml | ||
| package.json | ||
| .release-please-manifest.json | ||
| CHANGELOG.md | ||
| CHANGELOG.md | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm-lock.yamlis listed without any owners. In CODEOWNERS, each pattern line must include one or more owners (otherwise GitHub treats the line as invalid/ignored), so this entry currently has no effect. Add the intended owner(s) on this line (and consider anchoring it as/pnpm-lock.yamlif you only mean the repo-root lockfile).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong, no owner means anymore can review