chore: adding type transformer#35
Merged
kodiakhq[bot] merged 1 commit intomainfrom Aug 14, 2023
Merged
Conversation
erezrokah
approved these changes
Aug 14, 2023
|
|
||
| @Override | ||
| public boolean extensionEquals(ExtensionType other) { | ||
| if (!(other instanceof InetType)) |
Contributor
There was a problem hiding this comment.
wouldn't this work?
Suggested change
| if (!(other instanceof InetType)) | |
| return other instanceof InetType; |
Collaborator
Author
There was a problem hiding this comment.
Yes I think you are right. I was keeping with the style of other ArrowTypes, but I think they are generated code from this block.
I'll at the change as part of the next PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing tests for a type converter to convert types in a similar way to the current Go implementation.
InetTypeandJSONType- implementation to follow in future PRs.Listtype was created to reproduce theListOffunctionality present in the Go arrow SDK but not in the Java.fixes: #31