Skip to content

fix: Add pandas requirement to setup.py#10

Merged
hermanschaaf merged 1 commit intomainfrom
hermanschaaf-patch-1
Jul 31, 2023
Merged

fix: Add pandas requirement to setup.py#10
hermanschaaf merged 1 commit intomainfrom
hermanschaaf-patch-1

Conversation

@hermanschaaf
Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf commented Jul 31, 2023

Otherwise libraries importing the package need to install it themselves

@hermanschaaf hermanschaaf requested review from disq and yevgenypats July 31, 2023 15:40
@hermanschaaf hermanschaaf changed the title Add pandas requirement to setup.py fix: Add pandas requirement to setup.py Jul 31, 2023
@disq
Copy link
Copy Markdown
Member

disq commented Jul 31, 2023

There are also more requirements in requirements.txt... which might be wrong or somehow automatically added?

@hermanschaaf
Copy link
Copy Markdown
Contributor Author

They were probably added via pip freeze. In practice installing this version of pandas seems to give all the secondary requirements needed, but it would probably be better to add them all to setup.py as well 🤷

@hermanschaaf hermanschaaf merged commit 73b7036 into main Jul 31, 2023
@hermanschaaf hermanschaaf deleted the hermanschaaf-patch-1 branch July 31, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants