WIP: Hands on table update #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With handsontable 16 comes a new handsontable.full.css. This was renamed to .less to work with the existing style.less
Handontable stores the information which colmuns have been moved where in an internal-ish. This internal state can be explicitly set by the manualColumnMove or manualRowMove option. (see official handsontable documentation). We therefore reset this state its default values and directly apply the meved rows/columns to the data-array.
this.rootElement used to be a jQuery object, but this was changed upstream.
With a small change to the original so we have a class for every context-menu entry and hence better styles.
Member
|
I pushed some pixels for the split/merge icons: |
Member
|
Cool that you introduced some frontend tests. I wonder if we could integrate those with travis (via phantomjs) |
Member
|
Member
|
The styling on the edit button seems to be lost. Old: Now: |
less/foo.less
Outdated
Member
There was a problem hiding this comment.
Should this file really be called foo.less?
It is desireable to integrate frontend-javascript unittests with travis as well. This has been achived mainly by following this guide: https://jordankasper.com/automated-javascript-tests-using-grunt-phantomjs-and-qunit/
The pull requests for the two changes are: handsontable/handsontable#2736 handsontable/handsontable#2735
handsontable creates three clones, the purpose of which is unclear to me. One of those clones .ht_clone_top create the extra scrollbar on wide tables. Hide all those clones until we find an actual purpose for them.
Contributor
Author
|
The pull request for the change to 3rd party handsontable in ecf662d is there: handsontable/handsontable#2737 |
Contributor
Author
|
This pull request is also compatible with #54. Both should be mergeable together |
This was referenced Aug 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the current upstream Handsontable library (version 0.16.1). We still use the modification from handsontable/handsontable@a20e7ab
This especially means, that we are now using their built-in colum and row moving and cell=merging functionality,
There are still some things to be done/fixed:
The merge cells context menu entry needs an icondone in 18e7efaThe merge cells context menu entry should have a different string for merging and separating cellsdone in b905fc5Rows and Columns with merged cells should not be moveable, unless the merge the cells are only merged within the row/column to be moved.done in commit e3b1db0Changing the number of rows/cells in front a merged cell should correctly shift the merged cells, so that they remain in alignment with their original content. See also: Inserting rows/cols doesn't shift cell meta data handsontable/handsontable#1823done in commit c5dfef9decide what should happen if one row/column with some merged cells is deletedbehaviour is mostly as it was before, implemented in 05b6b29