Update common #26
Merged
Update common #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Münch <[email protected]>
Signed-off-by: Patrick Münch <[email protected]>
Signed-off-by: Patrick Münch <[email protected]>
Signed-off-by: Patrick Münch <[email protected]>
atomic111
force-pushed
the
update_common
branch
from
047722b to
edf1281
Compare
Signed-off-by: Patrick Münch <[email protected]>
chris-rock
approved these changes
Mar 27, 2019
Member
chris-rock
left a comment
chris-rock
left a comment
There was a problem hiding this comment.
Great improvements @atomic111 I added just one question.
controls/user_rights.rb
Outdated
| title '2.2.1 Set Access Credential Manager as a trusted caller to No One' | ||
| desc 'Set Access Credential Manager as a trusted caller to No One' | ||
| describe security_policy do | ||
| its('SeTrustedCredManAccessPrivilege') { should eq ['S-1-0-0'] } |
Member
There was a problem hiding this comment.
@atomic111 Whay have you changed this? Have we used the wrong values before?
Member
Author
There was a problem hiding this comment.
yes this is the wrong value, because in the CIS language "No one" means a blank value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare for the big pr