Resolve Issue #9 and various API improvements #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgray
commented
Sep 20, 2015
cgray
commented
- Added optional options parameter to static Wheniwork::login resolving issue No way to set endpoint for login #9
- Added processing for options to enable ssl_verifypeer, ca_info, and ca_path to created curl request.
- Changed request method verbs to up all uppercase. In RFC 2616 Sec 5.1.1 verbs are presented in all upper and I have heard issues with IIS treating verbs in case sensitive manner.
- Made setHeader replace internal representation of headers in a case insensitive manner per RFC 2616 Section 4.2
- Added Tests
Changed request method verbs to up all upper per RFC 2616 Made setHeader replace headers in a case insensitive manner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.