Group membership is not correct immediately after restoring a backup #3731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I typically restore a database, localmode @ commandline, so a db startup is done anyway :-/ |
adamretter
force-pushed
the
fix-restore-groups
branch
from
9db42ce to
b80d5aa
Compare
dizzzz
reviewed
Feb 15, 2021
exist-core/src/main/java/org/exist/backup/ZipArchiveBackupDescriptor.java
Show resolved
Hide resolved
dizzzz
reviewed
Feb 15, 2021
exist-core/src/main/java/org/exist/backup/FileSystemBackupDescriptor.java
Show resolved
Hide resolved
dizzzz
approved these changes
Feb 15, 2021
Contributor
Author
|
@dizzzz I added the logging as you requested. Let me know... ;-) |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3650
It absolutely blows my mind that until today only 2 people have recently reported this but yet the problem has been around for quite some time (at least 5.1.1 if not before). I wonder if anyone else is doing backups/restores of their databases?!?
This PR provides a fix that only addresses the problem for those users that restore full or incremental backups of the entire database, i.e. starting from
/db.Any partial restore that starts from
/db/systemor below and includes the users and groups will still not correctly load the groups before the users. Unfortunately solving such a thing with the current approach of the restore code is impossible, and the restore system itself needs rewriting to take a different approach. As most users backup and restore full-databases this should solve it for the majority.We may contribute a rewrite of the backup/restore system in future to fix a number of additional issues.