Skip to content

Update Homebrew release notes#3952

Closed
joewiz wants to merge 2 commits intoeXist-db:developfrom
joewiz:update-homebrew-docs
Closed

Update Homebrew release notes#3952
joewiz wants to merge 2 commits intoeXist-db:developfrom
joewiz:update-homebrew-docs

Conversation

@joewiz
Copy link
Copy Markdown
Member

@joewiz joewiz commented Jun 27, 2021

Description:

This PR updates the eXist release documentation with recent changes in Homebrew:

  1. As of Homebrew 2.6.0:

    All brew cask commands have been deprecated in favour of brew commands (with --cask) when necessary.

  2. The old cask-repair utility is deprecated:

    cask-repair is deprecated. I will accept PRs to fix bugs, but spending more time on it is difficult to justify. I recommend using brew bump-cask-pr. It doesn’t do as much in niche cases, but it does more in other slightly more relevant cases. It covers the vast majority os bump needs better. It ships in Homebrew, so there’s nothing to install. Do brew bump-cask-pr --help to see how to use it.

This switches our procedure to use the new, official brew bump-cask-pr utility recommended in the eXist CONTRIBUTING document.

Reference:

  1. https://brew.sh/2020/12/01/homebrew-2.6.0/
  2. vitorgalvao/tiny-scripts@09b68e4#diff-47b6313694b8a6f736f1a394498f41d0a0088b1ddf3277b1758d2bf7385e043f
  3. https://github.com/Homebrew/homebrew-cask/blob/master/CONTRIBUTING.md

Type of tests:

n/a

@line-o
Copy link
Copy Markdown
Member

line-o commented Jun 27, 2021

Thanks for taking the time and updating the documentation.
Could you also add that to the pad were we track findings from the last release?
Otherwise I fear your additions might get lost.

@joewiz
Copy link
Copy Markdown
Member Author

joewiz commented Jun 27, 2021

@line-o I'm not quite following how the changes in this PR could get lost. Could you expand a bit on plans for how that pad is going to be used? (This one, correct?) My sense is that the pad was temporary and purely to aid in collaborative editing of a file that would be migrated back to permanent storage here. If that needs to be migrated back first before we apply this PR, that would be fine. But if you're proposing keeping eXist release documentation outside of this file, I think this would need to be discussed first, i.e., at a community call.

@joewiz joewiz force-pushed the update-homebrew-docs branch from b07f156 to db19130 Compare June 27, 2021 13:41
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@windauer
Copy link
Copy Markdown
Member

@joewiz for sure the content of the pad should go into the release howto and there are no intentions that it leaves anywhere else. I guess Juri wanted to avoid bit more complex merging by asking you to put the content directly in the pad. But since @joewiz only touched the homebrew part and @line-o and me only other parts merging will be easy and I don't see any issues to merge this PR already! Ours is to come very soonish as well.

@joewiz
Copy link
Copy Markdown
Member Author

joewiz commented Jun 27, 2021

@windauer Ah, ok. Perhaps it's best if you prepare your PR first, since your changes may be more global. I can rebase/adjust once yours is merged. No rush on getting this merged.

@joewiz joewiz marked this pull request as draft June 27, 2021 15:48
@line-o
Copy link
Copy Markdown
Member

line-o commented Jun 30, 2021

@joewiz #3962 is the PR with the updated guide how-to release exist-db

@joewiz
Copy link
Copy Markdown
Member Author

joewiz commented Jun 30, 2021

@line-o Great, thanks! I'll rebase this and mark it ready for review as soon as #3962 is merged.

@line-o line-o added this to the eXist-5.3.1 milestone Jul 1, 2021
@adamretter adamretter modified the milestones: eXist-5.3.1, eXist-5.3.2 Dec 16, 2021
@joewiz
Copy link
Copy Markdown
Member Author

joewiz commented Jan 31, 2022

Closed by #4141.

@joewiz joewiz closed this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants