Skip to content

[test] rewrite util:expand jUnit tests to XQSuite #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
line-o wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[test] rewrite util:expand jUnit tests to XQSuite #4289

line-o wants to merge 1 commit into from

Conversation

@line-o
Copy link
Member

@line-o line-o commented Mar 25, 2022

Description:

  • DOM and Query are syntax highlighted and not just strings in XQSuite
  • all util:expand tests are now in one location
  • add test for processing instruction before root node in persistent DOM

Reference:

Type of tests:

XQSuite

@line-o
[test] rewrite util:expand jUnit tests to XQSuite
4a10c2b 
- DOM and Query are syntax highlighted and not just strings in XQSuite
- all util:expand tests are now in one location
- add test for processing instruction before root node in persistent DOM
@line-o line-o requested a review from a team March 25, 2022 13:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adamretter
Copy link
Contributor

adamretter commented Mar 26, 2022 •
edited
Loading

@line-o I undertook the work to fix util:expand and added the Java tests. I do not mind you adding additional tests, but I do not want the Java tests removed. The Java tests were key to helping me debug and fix the issues in Java.

As mentioned in the past, the problem with XQSuite tests is they make Java debugging more complex and not simpler, please keep that in mind!

adamretter
adamretter suggested changes Mar 26, 2022
View reviewed changes
Copy link
Contributor

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reinstate the Java tests that I created as these were key to fixing the problem, the XQSuite tests are not a substitute for them.

dizzzz
dizzzz requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert some of the changes as requested by adam

@adamretter
Copy link
Contributor

adamretter commented Oct 5, 2022

@line-o Should this be closed?

@line-o line-o marked this pull request as draft May 7, 2025 22:31
@line-o line-o added this to v7.0.0 May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dizzzz dizzzz dizzzz requested changes

+1 more reviewer

@adamretter adamretter adamretter requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

v7.0.0
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@line-o @adamretter @dizzzz