[bugfix] Fix ignored namespace binding conflict#4507
[bugfix] Fix ignored namespace binding conflict#4507chris-evolvedbinary wants to merge 2 commits intoeXist-db:developfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
dizzzz
left a comment
dizzzz
left a comment
There was a problem hiding this comment.
Please add a (set of) test(s) as provided in the nice original problem report.
line-o
left a comment
line-o
left a comment
There was a problem hiding this comment.
Looks good but I do not see any tests for it. I would prefer them to be XQSuite tests.
adamretter
left a comment
adamretter
left a comment
There was a problem hiding this comment.
I have just attempted the test in the linked issue. Unfortunately it shows that this is not the correct solution to the problem. We cannot statically detect this at compile time as this PR attempts to do, the issue we are trying to solve can only be detected at runtime.
|
Can we close this PR, @adamretter? The linked issue is closed. |
duncdrum
added
the
awaiting-response
|
As this is not the right fix, and there are pending change request I’ll convert this to draft |
adamretter
force-pushed
the
bugfix/namespace-binding-conflict
branch
from
e906b1e to
4231785
Compare
line-o
added
close-without-action
5 participants
Description:
Add error when namespace binding conflict occurs.
Reference:
#1482
Type of tests:
Existing tests still work.
This open source contribution to the eXist-db project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.