Skip to content

Relax eXist functions that require parameter of type xs:anyURI to accept xs:string#4641

Closed
joewiz wants to merge 1 commit intoeXist-db:developfrom
joewiz:relax-anyuri-params-allow-string-2
Closed

Relax eXist functions that require parameter of type xs:anyURI to accept xs:string#4641
joewiz wants to merge 1 commit intoeXist-db:developfrom
joewiz:relax-anyuri-params-allow-string-2

Conversation

@joewiz
Copy link
Copy Markdown
Member

@joewiz joewiz commented Dec 7, 2022

Description:

As discussed on yesterday's community call, this is a new branch focusing first on a single function.

Reference:

#4632

Type of tests:

No new tests yet

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@joewiz
Copy link
Copy Markdown
Member Author

joewiz commented May 7, 2023

CI tests pass. Thus, this proves the concept. If we merge this we can begin work on others.

@joewiz joewiz marked this pull request as ready for review May 7, 2023 17:58
@joewiz joewiz changed the title WIP Relax eXist functions that require parameter of type xs:anyURI to accept xs:string Relax eXist functions that require parameter of type xs:anyURI to accept xs:string May 7, 2023
@joewiz joewiz added this to the eXist-7.0.0 milestone May 7, 2023
@joewiz joewiz added the enhancement new features, suggestions, etc. label May 7, 2023
@joewiz
Copy link
Copy Markdown
Member Author

joewiz commented May 7, 2023

... unless we want to wait on the outcome of qt4cg/qtspecs#480.

@duncdrum
Copy link
Copy Markdown
Contributor

@joewiz is this still WIP? Could you rebase please

@joewiz joewiz force-pushed the relax-anyuri-params-allow-string-2 branch from 4414819 to b26b46c Compare April 3, 2026 11:44
@joewiz joewiz requested a review from a team as a code owner April 3, 2026 11:44
@joewiz joewiz force-pushed the relax-anyuri-params-allow-string-2 branch from b26b46c to 392d718 Compare April 13, 2026 13:27
@joewiz
Copy link
Copy Markdown
Member Author

joewiz commented Apr 23, 2026

@duncdrum Rebased. This is no longer WIP. Also the WG accepted my proposal to allow type promotion of xs:string to xs:anyURI, I'll take action to review the XQuery 4 PRs to see if they picked this change up or not. I suggest we close this and rely on XQuery 4 to handle this for us - letting functions declare their expected types as specifically as they need (e.g., xs:anyURI when they expect a URI) but happily accepting strings if that's what they receive.

@joewiz joewiz force-pushed the relax-anyuri-params-allow-string-2 branch from 392d718 to e3f7a5f Compare April 23, 2026 13:42
@joewiz
Copy link
Copy Markdown
Member Author

joewiz commented Apr 23, 2026

[This response was co-authored with Claude Code. -Joe]

@duncdrum — rebased onto current develop (was 156 commits behind). The CI failures were from staleness, not from the change itself. Let's see if CI passes now.

@line-o line-o requested a review from a team April 23, 2026 15:21
@line-o
Copy link
Copy Markdown
Member

line-o commented Apr 23, 2026

Happy to merge or close this PR @joewiz

@joewiz
Copy link
Copy Markdown
Member Author

joewiz commented Apr 23, 2026

Thanks @line-o. With an eye to eXist 7 and XQuery 4, I'd say let's close this. The problem should take care of itself.

@joewiz joewiz closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new features, suggestions, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants