[bugfix] omit newline after doctype with indent=no#5370
[bugfix] omit newline after doctype with indent=no#5370line-o wants to merge 3 commits intoeXist-db:developfrom
Conversation
|
@dizzz yes I saw that too. I will push updates soon. |
|
|
If you load XML via |
|
@dizzzz this PR does only change the behaviour of the doctype. |
| "<!DOCTYPE bookmap PUBLIC \"-//OASIS//DTD DITA BookMap//EN\" \"bookmap.dtd\">\n" + | ||
| "<bookmap id=\"bookmap-1\"/>"; | ||
| "<!DOCTYPE bookmap PUBLIC \"-//OASIS//DTD DITA BookMap//EN\" \"bookmap.dtd\">" + | ||
| "<bookmap id=\"bookmap-1\"><title>The Title</title></bookmap>"; |
There was a problem hiding this comment.
Why add a child element here, it doesn't seem that it has changed anything else about the test?
There was a problem hiding this comment.
The child element was added to see the effect of indent=no to slightly more complex data.
adamretter
changed the title
line-o
changed the title
| @Test | ||
| public void testAttributeWithBooleanValue() throws Exception { | ||
| final String expected = "<!DOCTYPE html>\n<input checked>"; | ||
| final String expected = "<!DOCTYPE html><input checked>"; |
There was a problem hiding this comment.
would it be useful to have an other test with the \n still there, to show the (non?) effect of the changes?
|
@line-o please could you rebase? |
duncdrum
left a comment
duncdrum
left a comment
There was a problem hiding this comment.
I m surprised that the doctype doesn't have to be a line. But if it's legal the more compact syntax in this PR looks good.
4 participants
fixes #4736
Before
AFTER