Change duplicated variant.getJavaCompile() to variant.getJavaCompileP…#280
Closed
BearCola wants to merge 1 commit intoevant:masterfrom
Closed
Change duplicated variant.getJavaCompile() to variant.getJavaCompileP…#280BearCola wants to merge 1 commit intoevant:masterfrom
BearCola wants to merge 1 commit intoevant:masterfrom
Conversation
evant
requested changes
Jun 25, 2019
|
|
||
| private static configureCompileJavaTask(Project project, BaseVariant variant, RetrolambdaTransform transform) { | ||
| variant.javaCompile.doFirst { | ||
| variant.javaCompileProvider.get().doFirst { |
Owner
There was a problem hiding this comment.
By using get() we break the lazy configuration the provider introduces, should figure out another way to do it, probably with configure? https://docs.gradle.org/current/userguide/task_configuration_avoidance.html
Owner
|
Closing due to inactivity, feel free to re-open if you desire to work on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rovider()
Related issue #279