secret-handshake: update tests to canonical version v1.1.0#1085
secret-handshake: update tests to canonical version v1.1.0#1085cmccandless merged 7 commits intoexercism:masterfrom
Conversation
| import unittest | ||
|
|
||
| from secret_handshake import handshake, code | ||
| from example import handshake, code |
There was a problem hiding this comment.
Don't forget to revert this
| idx = newidx | ||
| s.reverse() | ||
| return s | ||
| def handshake(code): |
There was a problem hiding this comment.
I like your names for parameters, what do you think of updating https://github.com/exercism/python/blob/master/exercises/secret-handshake/secret_handshake.py for consistency?
| return actions if code < 16 else list(reversed(actions)) | ||
|
|
||
|
|
||
| def code(actions): |
There was a problem hiding this comment.
secret_code looks a bit better in this case I think
| self.assertEqual(code(['wink', 'sneeze']), '0') | ||
| # Track-specific tests | ||
|
|
||
| def test_code1(self): |
There was a problem hiding this comment.
Maybe we should skip tack-specific tests and let the user decide if he/she wants to write the code which passes them?
There was a problem hiding this comment.
I like that idea, since in this case the track-specific tests involve a method that isn't tested for in the canonical tests.
|
This issue has been automatically marked as |
2 participants
Resolves #1006