kindergarten-garden: improve example.py#1843
Merged
yawpitch merged 4 commits intoexercism:masterfrom Jul 10, 2019
yawpitch:master
Merged
kindergarten-garden: improve example.py#1843yawpitch merged 4 commits intoexercism:masterfrom yawpitch:master
yawpitch merged 4 commits intoexercism:masterfrom
yawpitch:master
Conversation
Eliminate mutable default value and incorrect use of name mangling. Minimize unused instance attributes and speed up performance.
Eliminate mutable default value and incorrect use of name mangling. Minimize unused instance attributes and speed up performance.
cmccandless
approved these changes
Jul 10, 2019
Contributor
|
This can be merged once the $ flake8
./exercises/kindergarten-garden/example.py:27:80: E501 line too long (80 > 79 characters)
The command "flake8" failed and exited with 1 during . |
cmccandless
reviewed
Jul 10, 2019
Contributor
Author
Sigh ... there's the issue with flake8 thinking 79 is 80. Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example.py has a mutable default, improperly named constants, and incorrectly invokes name mangling on a "non-public" class attribute. It's also inefficient.