Skip to content

use pytest in CI script#2328

Merged
BethanyG merged 6 commits intomainfrom
test-concept-exercises
Feb 6, 2021
Merged

use pytest in CI script#2328
BethanyG merged 6 commits intomainfrom
test-concept-exercises

Conversation

@cmccandless
Copy link
Contributor

Certain exercises were missing the unittest.main footer, preventing their tests from running in CI. As much of our tooling depends on pytest anyway, this PR changes the script to invoke pytest from the current Python executable. Will fail if pytest not installed for that Python version.

@cmccandless cmccandless requested a review from a team as a code owner February 6, 2021 03:36
@cmccandless cmccandless force-pushed the test-concept-exercises branch from d63a1d8 to 9b68017 Compare February 6, 2021 16:24
@cmccandless cmccandless force-pushed the test-concept-exercises branch from 9b68017 to ae35129 Compare February 6, 2021 17:02
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌟 Thank you for fixing this.

@BethanyG BethanyG merged commit 714e4f5 into main Feb 6, 2021
@BethanyG BethanyG deleted the test-concept-exercises branch February 6, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants