Implement exercise complex-numbers#523
Conversation
|
Good luck with this one and have fun 👍 @lilislilit |
lilislilit
changed the title
|
tests and example.py are both finished, so there is that. Humbly waiting for nitpicking and/or approval. |
ilya-khadykin
left a comment
ilya-khadykin
left a comment
There was a problem hiding this comment.
Looks good!
Only some small things can be improved further
| { | ||
| "uuid": "7f4d5743-7ab8-42ca-b393-767f7e9a4e97", | ||
| "slug": "complex-numbers", | ||
| "core": false, |
There was a problem hiding this comment.
Could you please share with us the reasoning behind this decision?
Don't get me wrong, I am not against it, just curios
And it turned out (while testing a new version of Exercism) that non-core exercise should be unlocked by only a core one.
We should revisit the whole track curriculum, perhaps you can help with a fresh view
There was a problem hiding this comment.
To be completely honest, I was looking at a c# track, it looks somewhat finished, so I figured that their unlocking graph is finished too. If we will be redoing the whole of dependency graph, maybe it warrants separate issue and separate PR?
There was a problem hiding this comment.
Yeah, this should be addressed in a separate issue\PR.
I didn't have a chance to create it, I'll create it later today
But still, it's better to leave unlocked_by empty for now (until we'll figure out a list of core exercises)
config.json
Outdated
| "uuid": "7f4d5743-7ab8-42ca-b393-767f7e9a4e97", | ||
| "slug": "complex-numbers", | ||
| "core": false, | ||
| "unlocked_by": "leap", |
There was a problem hiding this comment.
The same for difficulty.
What affected the score to be 6?
There was a problem hiding this comment.
Yeah, same hear. Took it from C# track. As I understood, difficulty grade is kinda... subjective.
There was a problem hiding this comment.
Agreed. Maybe we can come with some sort of formula to compute it, what do you think?
There was a problem hiding this comment.
I think this question maybe hurried somewhere in general discussions repo. Btw, will difficulty be used at all in version 2, or there would be relying on "unlocked_by" prerequisites?
In general, it could be done, of course, simplest heuristic would be to split topics that we have in to tiers, from simplest to hardest and add the difficulty level for each additional topic for exercise. So if basically tier_level1+....tier_level2
There was a problem hiding this comment.
@lilislilit, hm, this a really good point, thanks! I haven't thought about it this way
I've created the following issue exercism/discussions#193 in general discussion, feel free to add your thoughts there
| "core": false, | ||
| "unlocked_by": "leap", | ||
| "difficulty": 6, | ||
| "topics": [ |
There was a problem hiding this comment.
Good choice.
We are trying to standardize topics across all tracks and decided to use snake_case notation as a naming convention. List of of common topics can be found here - https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt
Could you please convert them to 'snake_case'
| @@ -0,0 +1,3 @@ | |||
| class ComplexNumber(object): | |||
| def __init__(self): | |||
There was a problem hiding this comment.
As it was discussed in #509 it would be a good idea to include expected parameters to not force the user to go through a test class
What are your thoughts on this?
There was a problem hiding this comment.
Yeah, I think it is a wise thing to do
There was a problem hiding this comment.
Although, should I also include method signatures? Or only params for constructor? If we don't want people to go through test suite too much, including method signatures makes sense, some tracks here do this.
There was a problem hiding this comment.
I guess it makes sense to include method signatures since the user uses the provided test suite anyway.
And if someone wants to create their own unique solution, they are free to change provided class placeholder or even test suite (rewrite it, add or remove tests)
I don't see how providing method signatures can influence the user's overall implementation. The most important thing for me is convenience
… added write-up for ComplexNumber template class
|
@lilislilit, everything looks good to me, thanks for taking the time and implementing this! Generally it would be a good idea to squash commits, but it's up to you |
…lit/python into exercise-complex-numbers
|
@m-a-ge From the looks of history, commits look squashed :) Also, thank you for your time. Looking forward to do some more stuff for this track |
|
Test cases |
|
@cmccandless could please create an issue describing the details? |
|
Done. See #527. |
|
@cmccandless thanks! |
3 participants
Trying to implement complex-numbers according to guideline. This is initial commit for WIP pull-request. Tests and example.py still needs to be finished.