matrix.py: adds parameter to init function#587
matrix.py: adds parameter to init function#587ilya-khadykin merged 2 commits intoexercism:masterfrom danishprakash:master
Conversation
adds a parameter to init method making it easier for users to understand the problem.
ilya-khadykin
left a comment
There was a problem hiding this comment.
Thanks
I left a comment for discussion
exercises/matrix/matrix.py
Outdated
| @@ -1,3 +1,3 @@ | |||
| class Matrix(object): | |||
| def __init__(self): | |||
| def __init__(self, matrix): | |||
There was a problem hiding this comment.
I think matrix is somewhat confusing name, since it just a string of numbers divided by newlines.
So, it would be more appropriate to name it as matrix_string or something else.
What do you think?
There was a problem hiding this comment.
True, made the required change.
adds a parameter to init method making it easier for users to understand the problem.
|
Thanks, @prakashdanish and congrats on your first contribution to the repo! Please note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge. It's a good practice to squash your commits https://github.com/exercism/docs/blob/master/contributing/git-basics.md#squashing. It isn't a big deal since I can do it myself, but it would be awesome to just click on 'Merge pull request' button 😃 Just for future reference a guide of how to write good commit messages - https://chris.beams.io/posts/git-commit/#seven-rules |
|
@m-a-ge Did you mean, I should've written something like |
|
@prakashdanish yes, the full list of words: |
adds a parameter to init method making it easier for users to understand the problem.
Fixes #572