scale generator: added default params to scale exercise template#683
Merged
ilya-khadykin merged 1 commit intoexercism:masterfrom Oct 7, 2017
Merged
Conversation
Contributor
|
Thanks, but please rename your commit: https://github.com/exercism/python#pull-requests |
lilislilit
changed the title
lilislilit
force-pushed
the
scale-generator-template-params
branch
2 times, most recently
from
ab77ce4 to
5e6eb02
Compare
lilislilit
force-pushed
the
scale-generator-template-params
branch
from
5e6eb02 to
fbd81ed
Compare
Contributor
|
Thanks, @lilislilit 👍 One more thing, if you'll add some special 'closing issue' keywords in description of your PR Github will take care of closing the corresponding issue automatically. It makes our work much easier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing PR for #635
Resolves #635