Implement exercise markdown#797
Implement exercise markdown#797ilya-khadykin merged 7 commits intoexercism:masterfrom Paul-Ilyin:markdown
Conversation
Paul-Ilyin
changed the title
|
Done |
ilya-khadykin
left a comment
ilya-khadykin
left a comment
There was a problem hiding this comment.
Thanks for your work!
I've left a couple of minor comments, please take a look
| "uuid": "1818f134-0ed9-e680-9b29-45ffd2b3344b0f841c7", | ||
| "slug": "markdown", | ||
| "difficulty": 3, | ||
| "topics": [ |
There was a problem hiding this comment.
Not sure that this topic is appropriate, could you please explain your reasoning?
You can use this list of general topics common among all tracks - https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt
There was a problem hiding this comment.
regular_expressions, pattern_matching are good candidates for example
There was a problem hiding this comment.
Look at this file:
"The markdown exercise is a refactoring exercise. There is code that parses a given string with Markdown syntax and returns the associated HTML for that string. Even though this code is confusingly written and hard to follow, somehow it works and all the tests are passing! Your challenge is to re-write this code to make it easier to read and maintain while still making sure that all the tests keep passing."
There was a problem hiding this comment.
@m-a-ge, this exercise is intended to be a refactoring exercise rather than an implementation one (see the README). This also explains the presence of a working solution (does TravisCI currently test this solution? I feel like it needs to) in markdown.py.
There was a problem hiding this comment.
@paulglass sorry, I've missed it due to amount of opened PRs 😕
@N-Parsons thanks!
No changes needed then 😄
|
|
||
|
|
||
| def parse_markdown(markdown): | ||
| lines = markdown.split('\n') |
There was a problem hiding this comment.
I think you forgot to replace an actual solution with an exercise placeholder for the learner.
Could you please fix this?
There was a problem hiding this comment.
Learner should refactor this code as I mentioned before.
| import unittest | ||
| from markdown import parse_markdown | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you please also leave a comment stating what version of canonical-data.json the tests were adopted as discussed in #784?
There was a problem hiding this comment.
@paulglass, the new format is:
# Tests adapted from `problem-specifications//canonical-data.json` @ v1.0.0
|
Thanks a lot for adding such an interesting exercise, @paulglass! |
3 participants
resolves #729
Want to implement this