Poker: added topics#918
Merged
ilya-khadykin merged 3 commits intoexercism:masterfrom Oct 15, 2017
e-zorzi:master
Merged
Conversation
added 2 commits
October 15, 2017 15:22
ilya-khadykin
suggested changes
Oct 15, 2017
Contributor
ilya-khadykin
left a comment
ilya-khadykin
left a comment
There was a problem hiding this comment.
Thanks for the PR
I've left a comment, please take a look
config.json
Outdated
| "difficulty": 1, | ||
| "topics": [ | ||
|
|
||
| "arrays", |
Contributor
There was a problem hiding this comment.
Could you please change it to lists.
In my mind arrays can store data only of the same type (in Java for example), but lists can store data of any type (like in Python or any implementation of List interface in Java)
Author
|
@m-a-ge done |
ilya-khadykin
approved these changes
Oct 15, 2017
Contributor
|
Thanks, @edo-vi It's a best practice to squash your commits https://github.com/exercism/docs/blob/master/contributing/git-basics.md#squashing. It isn't a big deal since I can do it myself, but it would be awesome to just click on 'Merge pull request' button 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #861