Hackathon blog post #106
Hackathon blog post #106
Conversation
mfisher87
force-pushed
the
hackathon-blog-post
branch
from
306fcd3 to
9556e7a
Compare
|
|
Thanks, great feedback Ciera! |
mfisher87
requested review from
arjxn-py,
brianna-corremonte,
brookisme and
iamciera
mfisher87
requested review from
GondekNP,
KirstieJane,
colliand,
fperez,
giswqs,
jasongrout,
kpdavi,
lucialayr,
mapninja,
maryamv,
minrk and
wildintellect
and removed request for
arjxn-py
lucialayr
left a comment
lucialayr
left a comment
There was a problem hiding this comment.
Hi Matt,
I made some suggestions on language and structure, feel free to ignore all of them if you don't agree :)
|
|
||
| Four distinct working groups quickly emerged: | ||
| infrastructure developers exploring development containers and development environment | ||
| setup, |
There was a problem hiding this comment.
Lot's of repetition of the word 'development' . I'd say infrastructure developers exploring containers and environment setups works just as well
There was a problem hiding this comment.
Wow, I knew there were 2 instances, but didn't notice the 3rd 😆
There was a problem hiding this comment.
I cut out one instance, but I'm not convinced "environment setup" is clear enough -- what about changing "infrastructure developers" to something else? 🤔
| Four distinct working groups quickly emerged: | ||
| infrastructure developers exploring development containers and development environment | ||
| setup, | ||
| documentation specialists testing tutorials with fresh eyes and filling in docs gaps, |
There was a problem hiding this comment.
'gaps in documentation'? 'docs gaps' sounds weird to be due to sound repetition
| something to learn, creating a multiplier effect where our diversity amplified | ||
| eachothers' contributions. | ||
|
|
||
| Four distinct working groups quickly emerged: |
There was a problem hiding this comment.
maybe add (1), (2), ... to structure the sentence, since it it quite long
There was a problem hiding this comment.
How do you feel about bullets? I feel like numbering might be less useful unless we reference those numbers later in the doc, and breaking the items up on to separate lines makes them feel more bite-size.
| > We worked on getting data out of the map layer, manipulating the data and making | ||
| > updates to the map. | ||
| > We showed this was possible through two different workflows: toggling layer visibility | ||
| > and getting geojson from layer source and turning it into a geopandas object. |
There was a problem hiding this comment.
getting a geojson from the layer source or even getting a geojson from the source layer?
There was a problem hiding this comment.
Though I didn't use "a geojson" because it just doesn't sound right to me. I think of GeoJSON like an uncountable noun; like I can "get sand" or "get some sand", I think of "get GeoJSON" or "get some GeoJSON". As opposed to countable, e.g. "pet a dog" / "get a GeoJSON". I might say "get a GeoJSON file" though 🤷
Not sure what's right, it's just the way I think of it :)
Co-authored-by: Lucia <[email protected]>
Co-authored-by: Lucia <[email protected]>
Co-authored-by: Lucia <[email protected]>
Co-authored-by: Lucia <[email protected]>
Co-authored-by: Lucia <[email protected]>
Co-authored-by: Lucia <[email protected]>
Co-authored-by: Lucia <[email protected]>
|
Here we go! |
🔍 Preview: https://geojupyter--106.org.readthedocs.build/en/106/
Note: This Pull Request preview is provided by ReadTheDocs. Our production website, however, is currently deployed with GitHub Pages.