strToUppercaseReducer is incorrect name#205
Closed
klequis wants to merge 1 commit into
Closed
Conversation
Chapter starts out with name of function as `strUppercaseReducer` but has one instance there "To" is added - `strToUppercaseReducer`.
Owner
|
Thanks for spotting this inconsistency, but it seems like half the references are one way and the other half the other -- your PR only fixes one of them. Not sure which half of them should be changed, but we should get all of them in the chapter to have the same name, to eliminate confusion. |
Contributor
Author
|
I'll fix the others and use variant with "to" in it since i like it better :) |
Contributor
Author
|
Superseded by #206 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chapter starts out with name of function as
strUppercaseReducerbut has one instance there "To" is added -strToUppercaseReducer.