Add Hint and MaxTimeMS support to Count()#461
Open
fmpwizard wants to merge 4 commits intogo-mgo:v2-unstablefrom
Open
Add Hint and MaxTimeMS support to Count()#461fmpwizard wants to merge 4 commits intogo-mgo:v2-unstablefrom
fmpwizard wants to merge 4 commits intogo-mgo:v2-unstablefrom
Conversation
technically speaking, 2.5.5 for the Hint feature
travis is failing for most (all?) PRs even when the exit code is 0. This only happens for the two older mongo versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Hint and MaxTimeMS to the countCmd struct.
Added two unit tests covering the changes.
I had to uncomment the
.envfile because locally I run mongo 3.2, if this messes anything else, I can undo it.I have been using the Hint part of this patch for several months on production on collections with several millions of documents and works well :)
Fixes https://github.com/go-mgo/mgo/issues/364