Skip to content

Conversation

@aksg87
Copy link
Collaborator

@aksg87 aksg87 commented Sep 1, 2025

Summary

Refactors alignment parameter implementation to use existing resolver_params instead of adding new alignment_params parameter.

Changes

  • Uses existing resolver_params dictionary to avoid API proliferation
  • Centralizes alignment keys as immutable constant in resolver.py
  • Splits params cleanly between Resolver and annotator layers
  • Adds comprehensive test coverage and error handling

Alignment Parameters

Available through resolver_params:

  • enable_fuzzy_alignment: Use fuzzy matching if exact fails
  • fuzzy_alignment_threshold: Token overlap ratio (0.0-1.0)
  • accept_match_lesser: Accept partial exact matches

This is an alternative implementation of #211 that resolves merge conflicts while maintaining all performance optimizations.

cc @Skippou

Pass alignment parameters (enable_fuzzy_alignment, fuzzy_alignment_threshold,
accept_match_lesser) through existing resolver_params dictionary.

- Centralize alignment keys in resolver.py as immutable constant
- Split params between Resolver and annotator with None filtering
- Add helpful error messages for mistyped keys
- Add comprehensive test coverage
@github-actions github-actions bot added the size/M Pull request with 150-600 lines changed label Sep 1, 2025
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

⚠️ Branch Update Required

Your branch is 1 commits behind main. Please update your branch to ensure CI checks run with the latest code:

git fetch origin main
git merge origin/main
git push

Note: Enable "Allow edits by maintainers" to allow automatic updates.

@aksg87 aksg87 closed this Sep 1, 2025
@aksg87 aksg87 deleted the pr-211-resolver-params-refactor branch September 1, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Pull request with 150-600 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant