Skip to content

factory: auto-detect OPENAI_API_KEY for o1-* model IDs #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chinmaynadgir wants to merge 1 commit into
base: main
Choose a base branch
from
Open

factory: auto-detect OPENAI_API_KEY for o1-* model IDs #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions langextract/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ def _kwargs_with_environment_defaults(
env_vars_by_provider = {
"gemini": ("GEMINI_API_KEY", "LANGEXTRACT_API_KEY"),
"gpt": ("OPENAI_API_KEY", "LANGEXTRACT_API_KEY"),
"o1": ("OPENAI_API_KEY", "LANGEXTRACT_API_KEY"),
}

for provider_prefix, env_vars in env_vars_by_provider.items():
Expand Down
8 changes: 8 additions & 0 deletions tests/factory_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,14 @@ def test_uses_openai_api_key_from_environment(self):
model = factory.create_model(config)
self.assertEqual(model.api_key, "env-openai-key")

@mock.patch.dict(os.environ, {"OPENAI_API_KEY": "env-openai-key"})
def test_uses_openai_api_key_for_o1_models(self):
"""Factory should use OPENAI_API_KEY from env for 'o1-*' OpenAI models."""
config = factory.ModelConfig(model_id="o1-mini")

model = factory.create_model(config)
self.assertEqual(model.api_key, "env-openai-key")

@mock.patch.dict(
os.environ, {"LANGEXTRACT_API_KEY": "env-langextract-key"}, clear=True
)
Expand Down
Loading