fix: Add raw_generated_gql to intermediate_steps when verify_gql is True #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
|
cc: @mtyin |
mtyin
reviewed
May 7, 2025
| generated_gql = extract_gql(gen_response) | ||
|
|
||
| if self.verify_gql: | ||
| intermediate_steps.append({"raw_generated_gql": generated_gql}) |
Collaborator
There was a problem hiding this comment.
You may want to move this right above L314: intermediate_steps.append({"verified_gql": verified_gql}).
As in other cases, generated_gql is already part of the intermediate_steps.
Contributor
Author
There was a problem hiding this comment.
Sure. Done. Makes sense also from a consumer point of view, if you have verified_gql you will have raw_generated_gql.
mtyin
approved these changes
May 8, 2025
Collaborator
mtyin
left a comment
mtyin
left a comment
There was a problem hiding this comment.
LGTM, thanks for making the change!
Contributor
Author
|
Rewrote commit message to pass Conventional Commits |
Collaborator
|
/gcbrun |
averikitsch
changed the title
Collaborator
|
/gcbrun |
mtyin
approved these changes
May 23, 2025
Collaborator
|
/gcbrun |
2 similar comments
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
kurtisvg
approved these changes
Jul 22, 2025
averikitsch
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #173