feat: SpannerChatMessageHistory implementation #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
averikitsch
requested changes
Feb 6, 2024
averikitsch
requested changes
Feb 7, 2024
docs/chat_message_history.ipynb
Outdated
| "cell_type": "code", | ||
| "outputs": [], | ||
| "source": [ | ||
| "To run this notebook, you will need a Google Cloud Project, a Cloud Spanner instance, and Google credentials." |
Collaborator
There was a problem hiding this comment.
Move this to to the markdown section above and add links to each item: https://console.cloud.google.com/project, https://cloud.google.com/spanner/docs/create-manage-databases ,https://googleapis.dev/python/google-api-core/latest/auth.html
docs/chat_message_history.ipynb
Outdated
| { | ||
| "cell_type": "markdown", | ||
| "source": [ | ||
| "%pip install langchain-google-spanner" |
Collaborator
There was a problem hiding this comment.
This should be a code cell
averikitsch
reviewed
Feb 7, 2024
averikitsch
reviewed
Feb 7, 2024
averikitsch
reviewed
Feb 16, 2024
Collaborator
averikitsch
left a comment
averikitsch
left a comment
There was a problem hiding this comment.
Doc fixes can be prioritized separately
rahul2393
force-pushed
the
memory
branch
6 times, most recently
from
b0af3cf to
0b1f6df
Compare
averikitsch
approved these changes
Feb 20, 2024
averikitsch
reviewed
Feb 20, 2024
averikitsch
requested changes
Feb 20, 2024
Collaborator
averikitsch
left a comment
averikitsch
left a comment
There was a problem hiding this comment.
Please let me know if the user agent will be added in this PR or separately.
Contributor
Author
|
@averikitsch Added user agent support |
averikitsch
approved these changes
Feb 21, 2024
gauravpurohit06
approved these changes
Feb 21, 2024
| COLUMN_NAME = "history" | ||
|
|
||
|
|
||
| def client_with_user_agent( |
Contributor
There was a problem hiding this comment.
Keeping a note: We will create a common utility at the module layer once all the changes are checked in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕