feat: add document loader #9
Conversation
product-auto-label
bot
added
the
api: spanner
Yuan325
force-pushed
the
doc-loader
branch
3 times, most recently
from
12cfd97 to
96b9b00
Compare
Yuan325
force-pushed
the
doc-loader
branch
4 times, most recently
from
09172ac to
6706a5d
Compare
Yuan325
force-pushed
the
doc-loader
branch
3 times, most recently
from
7188997 to
78d1aab
Compare
Yuan325
force-pushed
the
doc-loader
branch
2 times, most recently
from
10c2257 to
9b7b9c4
Compare
Yuan325
force-pushed
the
doc-loader
branch
2 times, most recently
from
169a5ea to
8315d9d
Compare
| if type(self.staleness) is float | ||
| else None | ||
| ) | ||
| snapshot = db.batch_snapshot(exact_staleness=duration, read_timestamp=timestamp) |
There was a problem hiding this comment.
why we are passing both? we can just check and pass, right?
There was a problem hiding this comment.
One or the other should be "None", therefore simplifying the code by not needing conditionals.
| if type(self.staleness) is float | ||
| else None | ||
| ) | ||
| snapshot = db.batch_snapshot(exact_staleness=duration, read_timestamp=timestamp) |
There was a problem hiding this comment.
We should support all the four options:
- read_timestamp: Optional[datetime.datetime] = None,
- min_read_timestamp: Optional[datetime.datetime] = None,
- max_staleness: Optional[datetime.timedelta] = None,
- exact_staleness: Optional[datetime.timedelta] = None,
There was a problem hiding this comment.
The design was scoped to just read_timestamp and exact_staleness
| ) | ||
| for doc in documents | ||
| ] | ||
| keys = [[doc[0]] for doc in docs] |
There was a problem hiding this comment.
I guess it won't work if the primary key is composite?
There was a problem hiding this comment.
Added another argument in DocumentSaver -- primary key. and used that to build the self._table_fields in the init method. The self._table_fields will be built such as the primary key is always the first in the list. This will ensure that the first field in the tuple will always be the primary key. Thank you for the review!
3 participants
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕