refactor: Update to nuqs 2.8 and apply refactors#1782
Conversation
nuqs v2 requires NuqsAdapter to be added at the app root when using the Next.js Pages Router. The parseAsStringWithNewLines workaround (patching newline encoding) is no longer needed as v2.2.3+ handles this natively. Co-authored-by: Cursor <cursoragent@cursor.com>
- Migrate all useQueryParam/useQueryParams calls to nuqs useQueryState/useQueryStates - Remove use-query-params, next-query-params, and serialize-query-params packages - Remove @jedmao/location (test utility no longer needed) - Delete custom useQueryParam.tsx hook and fixtures.ts (replaced by NuqsTestingAdapter) - Strip QueryParamProvider/NextAdapter/HDXQueryParamProvider from _app.tsx and storybook - Update jest.config.js to transform nuqs (ESM package) for unit tests - Rewrite timeQuery.test.tsx using NuqsTestingAdapter and remove describe.skip Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review: nuqs v1 → v2 + use-query-params removalNo critical issues found. Clean, well-scoped migration. Notable observations:
Generated with Claude Code |
PR Review: nuqs v1 → v2 migration + remove use-query-paramsClean dependency consolidation. A couple of things worth checking:
🤖 Generated with Claude Code |
E2E Test Results❌ 8 tests failed • 63 passed • 4 skipped • 1137s
Tests ran across 4 shards in parallel. |
Fixes: HDX-2558
What Changed
nuqs v1 → v2 upgrade
Removed use-query-params
Fixed: side panel close handlers
Tests