Skip to content

refactor: Organize team page with tabs and refactor into separate components#1878

Open
teeohhem wants to merge 5 commits intomainfrom
tom/redesign-team-page
Open

refactor: Organize team page with tabs and refactor into separate components#1878
teeohhem wants to merge 5 commits intomainfrom
tom/redesign-team-page

Conversation

@teeohhem
Copy link
Contributor

Summary

Refactors team page into various components. Adds tabbed interface to keep things organized.

Screenshots or video

image image image image

How to test locally or on Vercel

Needs to be tested locally. Navigate to the team page.

References

N/A

@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 10, 2026 9:05pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2026

⚠️ No Changeset found

Latest commit: 5288391

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

E2E Test Results

All tests passed • 88 passed • 3 skipped • 925s

Status Count
✅ Passed 88
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@hyperdxio hyperdxio deleted a comment from github-actions bot Mar 10, 2026
@hyperdxio hyperdxio deleted a comment from github-actions bot Mar 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

PR Review

Clean refactoring — extracts monolithic TeamPage into well-scoped components with tab navigation. No new critical bugs or security regressions introduced. The hasAdminAccess = true pattern already existed in main and is pre-existing technical debt.

Minor issues worth noting:

  • ⚠️ useEffect redirects to ?tab=data on every fresh page load (no tab param) → adds an extra history entry on initial visit, which can feel like an extra back-button press. Consider only replacing the URL if a tab was already present, or use router.replace only when explicitly needed.

  • ⚠️ [activeTab, router] in both handleTabChange deps and useEffect deps — the full router object reference can change on every render. Consider using [activeTab, router.pathname, router.replace] to avoid unnecessary re-renders.

  • ℹ️ scrollbarGutter: 'stable' in layout.tsx requires Safari 16.4+ — will silently degrade on older Safari (minor, no functional regression).

✅ All tab navigation, component extraction, and E2E test updates look correct. No functional regressions detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant