feat: show inline span durations in trace timeline#1886
Open
karl-power wants to merge 1 commit intomainfrom
Open
feat: show inline span durations in trace timeline#1886karl-power wants to merge 1 commit intomainfrom
karl-power wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 98f711e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
PR Review
✅ No critical bugs or security issues. The feature logic is sound — spans show durations, logs don't, and placement (left/right of midpoint) is correct. |
Contributor
E2E Test Results✅ All tests passed • 86 passed • 3 skipped • 979s
Tests ran across 4 shards in parallel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds duration labels next to each span bar in the trace waterfall timeline so users can read the duration at a glance without hovering the tooltip.
Changes
Timeline chart
12ms,1.2s) outside each bar usingposition: absolute, so it doesn’t affect layout.maxVal / 2), to keep it in the emptier side.renderMs()fromTimelineChart/utilsfor formatting.overflow: visibleso the duration label is not clipped by the bar’stext-truncate(overflow hidden).showDuration?: boolean. Whenfalse, the duration label is hidden (default is to show).DBTraceWaterfallChart
showDuration: type !== SourceKind.Logso log rows do not show a duration (only spans do).Screenshots
Testing
References