Skip to content

Conversation

@stereobooster
Copy link
Contributor

Up to you - if you like this refactoring or not

@stereobooster
Copy link
Contributor Author

hm strange... tests (github CI) are not running for pull request

@stereobooster
Copy link
Contributor Author

And there is second-copy of store in Facets - this._items_map. Maybe it can be refactored somehow to store only copy of "map".

@cigolpl
Copy link
Member

cigolpl commented Nov 9, 2023

Yes, the code looks much cleaner now, is more readable and uses modern JS.

hm strange... tests (github CI) are not running for pull request

IMO .github/workflows/push.yml is missing pull_request in 3rd line

on: [push, pull_request]

@cigolpl cigolpl merged commit 5f25254 into itemsapi:master Nov 9, 2023
@stereobooster stereobooster deleted the refactor-fulltext branch November 9, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants