Skip to content

Hardening suggestions for insecure-kubernetes-deployments / insecure-api #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pixeebot wants to merge 1 commit into from
Closed

Hardening suggestions for insecure-kubernetes-deployments / insecure-api #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions insecure-api/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ def search_games(query: str):
conn = sqlite3.connect('videogames.db')
cursor = conn.cursor()
# BAD: Directly inserting user input into SQL query without sanitization
sql_query = f"SELECT * FROM video_games WHERE title LIKE '%{query}%'"
cursor.execute(sql_query)
sql_query = "SELECT * FROM video_games WHERE title LIKE ?"
cursor.execute(sql_query, ('%{0}%'.format(query), ))
rows = cursor.fetchall()
conn.close()
# Convert rows to list of dictionaries
Expand Down