Skip to content

✨ (Snyk) Fixed finding: "SQL Injection" #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

✨ (Snyk) Fixed finding: "SQL Injection" #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions insecure-api/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ def search_games(query: str):
conn = sqlite3.connect('videogames.db')
cursor = conn.cursor()
try:
sql_query = f"SELECT * FROM video_games WHERE title = '{query}'"
cursor.execute(sql_query)
sql_query = "SELECT * FROM video_games WHERE title = ?"
cursor.execute(sql_query, (query,))
rows = cursor.fetchall()
except Exception as e:
# Return the exception message for educational purposes (not recommended in production)
Expand Down
4 changes: 2 additions & 2 deletions insecure-app/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ def index():
username = request.form['username']
try:
# Vulnerable SQL query using string interpolation
query = "SELECT password FROM users WHERE username = '{}'".format(username)
cursor.execute(query)
query = "SELECT password FROM users WHERE username = %s"
cursor.execute(query, (username,))
result = cursor.fetchone()
if result:
output = f"Password for {username}: {result[0]}"
Expand Down
Loading