Skip to content

Conversation

@rht
Copy link
Contributor

@rht rht commented Dec 5, 2022

No description provided.

@valer-cara
Copy link

Not a pip expert, but I believe that the version specifier needs to be mesa~=1.1.0 when used with ~= https://peps.python.org/pep-0440/#compatible-release in order to keep to 1.1.

mesa~=1.1 is equivalent to mesa==1.* which in turn installs the later incompatible version.

@Corvince
Copy link
Contributor

You are correct with everything related to pip version management, but this PR is fine. Pinning to 1.y is correct, since increasing the minor version number (the y) must not include breaking changes.

So for example new features might be added, but nothing backwards incompatible. That would require a version 2.y

@valer-cara
Copy link

Indeed, however 1.2.(1?) minor version update seems to introduce some breaking changes by making model.space.Grid private (renaming to _Grid) which threw some errors, for example Conway with mesa 1.2.1, which is fixed by moving to 1.1.

AttributeError: module 'mesa.space' has no attribute 'Grid'. Did you mean: '_Grid'?

@Corvince
Copy link
Contributor

Corvince commented Apr 4, 2023

Good catch! We should probably release a bug fix release where Grid is only deprecated, not removed. @rht @tpike3 @jackiekazil

@jackiekazil
Copy link
Member

LGTM to me.

@jackiekazil jackiekazil merged commit 0f8dccd into mesa:main Apr 5, 2023
@rht rht deleted the reqs branch April 11, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants