Skip to content

Docker support#16

Closed
j4qfrost wants to merge 4 commits intomitmath:masterfrom
j4qfrost:master
Closed

Docker support#16
j4qfrost wants to merge 4 commits intomitmath:masterfrom
j4qfrost:master

Conversation

@j4qfrost
Copy link

@j4qfrost j4qfrost commented Sep 6, 2020

Hope this is helpful.

@dpsanders
Copy link
Collaborator

Thanks! In my experience just installing and running Docker is rather tricky.

README.md Outdated

Problem sets consist of code. MIT students enrolled in the course must submit homeworks via Canvas. If you are not a student then we encourage you to join the Discord and find a cross-grading partner.

### Quickstart
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Quick start using Docker"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In my experience just installing and running Docker is rather tricky.

I did consider that this might cause more issues than it fixes. Windows Home edition doesn't allow virtualization, so this might not be usable by a lot of students. I'm fine with just letting this sit, or if you would rather close the request I'm cool with that too.

@fonsp
Copy link
Member

fonsp commented Sep 6, 2020

It's great that you wrote it into a Docker image, but I think that this is more appropriate as part of Pluto.jl or PlutoUtils.jl - have a look at this work here:
fonsp/PlutoUtils.jl#5
fonsp/PlutoUtils.jl#3

This course should be simple and clear, and I think that this adds a complicated option that is not suitable for newcomers.

A final comment is that the git repository for this course changes constantly, and is meant to be read via the new website, not by manually updating a docker instance or pulling changes to a clone. In other words, using the docker image does not make it easier to follow the course during the coming months.

Perhaps you could take a look at the links I sent to see if you can contribute there? This part of Pluto still needs some work. And at the end of this course, we could revisit the option of including a Docker file in 18S191 again.

@j4qfrost
Copy link
Author

j4qfrost commented Sep 6, 2020 via email

@j4qfrost j4qfrost closed this Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants