Changed from SimpleGrantedAuthority to GrantedAuthority. Suggested fix to #1040#1043
Open
mobilars wants to merge 2 commits intomitreid-connect:masterfrom
Open
Changed from SimpleGrantedAuthority to GrantedAuthority. Suggested fix to #1040#1043mobilars wants to merge 2 commits intomitreid-connect:masterfrom
mobilars wants to merge 2 commits intomitreid-connect:masterfrom
Conversation
|
Are you planning in merging this PR @jricher ? |
|
I'm interested, too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in issue #1040 I have submitted a pull request where I've changed from simpleGrantedAuthority to GrantedAuthority in the SimpleGrantedAuthorityStringConverter class. I guess given that the SimpleGrantedAuthorityStringConverter class has this name, one could also change the class name and refering files, but I haven't done this.
This is my first pull request ever, so I hope it works. But don't feel obliged to accept it, it's a suggestion more than a definitive solution. But it does solve my problem here with the cast exception.