Add a benchmark of MessageBufferInput#reset#129
Merged
xerial merged 2 commits intov07-developfrom Aug 11, 2014
Merged
Conversation
Member
|
Good test :) It looks like the only overhead in
|
xerial
added a commit
that referenced
this pull request
Aug 11, 2014
Add a benchmark of MessageBufferInput#reset
Member
|
Updated msgpack-core-0.7.0-SNAPSHOT.jar |
xerial
added a commit
that referenced
this pull request
Aug 11, 2014
xerial
added a commit
that referenced
this pull request
Aug 11, 2014
Member
|
Optimization of 65f5dd1 improved the overall performance: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@xerial I added a benchmark test of MessageBufferInput#reset (ArrayBufferInput#reset). But there is no difference between the results which using reset() or not. So I've disabled the test with
ignoretag to avoid a test failure.Can you see if there is room to improve the performance of reset() with this test? It seems that ArrayBufferInput#reset always recreates a new buffer and to reuse the buffer can improve the performance. Thanks.