Remove calling of the old resource in reset()#175
Merged
xerial merged 2 commits intov07-developfrom Jan 16, 2015
Merged
Conversation
Member
Author
|
@xerial Can you review this PR? |
Member
There was a problem hiding this comment.
How about returning the old MessageBufferOutput instance here?
Member
|
@komamitsu If not, simply using void is OK. |
Member
Author
|
@xerial Thanks. I fixed them again. Can you review it again? |
Member
|
looks good. Thanks! |
xerial
added a commit
that referenced
this pull request
Jan 16, 2015
Remove calling of the old resource in reset()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #173.