Skip to content

Add MessagePacker.totalWrittenBytes#195

Closed
slandelle wants to merge 1 commit intomsgpack:v07-developfrom
slandelle:byteswritten
Closed

Add MessagePacker.totalWrittenBytes#195
slandelle wants to merge 1 commit intomsgpack:v07-developfrom
slandelle:byteswritten

Conversation

@slandelle
Copy link
Contributor

@slandelle slandelle commented Feb 9, 2015

This PR adds the ability to track the number of bytes a MessagePacker has packed.

@slandelle
Copy link
Contributor Author

slandelle commented Feb 9, 2015

@xerial ping :)

@xerial
Copy link
Member

xerial commented Feb 10, 2015

Thanks. I feel ensureCapacity is not a good place to embed this counter. I'll reorganize the code based on your changes so that totalWrittenBytes and position variables are synchronized.

xerial added a commit to xerial/msgpack-java that referenced this pull request Feb 10, 2015
@xerial
msgpack#195: Add MessagePacker.getTotalWrittenBytes
ad7b194
@xerial xerial mentioned this pull request Feb 10, 2015
Merged
@xerial
Copy link
Member

xerial commented Feb 10, 2015

I created a new PR based on your commits: #196

@xerial xerial closed this Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slandelle @xerial