Google App Engine Support

[xerial]

Fixes for #194:

• Refactored MessageBuffer to isolate the initialization steps between standard and Java6/Android/GAE platforms.
• Extracted DirectBufferAccess code to a new file.

I confirmed with this fix, we can initialize MessageBuffer class in GAE platform.

[xerial]

@komamitsu
Could you review the changes? Thanks in advance.

[xuwei-k]

I haven't been able to understand all changes, but I confirmed this code works on Google App Engine.
nice work 👍

xuwei-k/msgpack-json@00c289901a26396498f8ab

[komamitsu]

Minor: This variable isn't used

[xerial]

Removed. Thanks

[komamitsu]

How about something like this to make it more robust?

try {
    if (!isUniversalBuffer) {
            :
        boolean isLittleEndian = ByteOrder.nativeOrder() == ByteOrder.LITTLE_ENDIAN;
         if(isLittleEndian) {
             bufferClsName = "org.msgpack.core.buffer.MessageBuffer";
         }
         else {
             bufferClsName = "org.msgpack.core.buffer.MessageBufferBE";
         }
    }
}
catch {
   // Let's use MessageBufferU
}
if (bufferClsName == null) {
    bufferClsName = "org.msgpack.core.buffer.MessageBufferU";
        :
}

[xerial]

Good idea. With this fix, msgpack-java works anyway. To do this, I need to put the initialization code of static fields (bufferClsName, unsafe, etc.) after the last catch call.

[xerial]

Fixed in 5fd6964

[komamitsu]

Looks good

[komamitsu]

It worked on Android 2.3.3, 4.0.4 and 5.0 :)