Skip to content

V07 value impl #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 39 commits into from
Jun 23, 2015
Merged

V07 value impl #246

Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
2242fe4
implemented Value API
frsyuki Jun 10, 2015
7685276
added org.msgpack.value.Variable
frsyuki Jun 10, 2015
3393110
implemented Variable.hashCode, equals, toString, and writeTo methods
frsyuki Jun 10, 2015
a40cbcb
fixed Value API
frsyuki Jun 10, 2015
2ff4f59
ImmutableMapValueImpl.equals should not assume order of elements is same
frsyuki Jun 10, 2015
e2fc4e6
Renmae ExtendedType -> ExtensionType
xerial Jun 13, 2015
bc7e503
ValueFactory.newXXXValue -> newXXX for brevity
xerial Jun 13, 2015
b123089
immutableValue() -> toImmutable()
xerial Jun 13, 2015
4bcfab5
Add visitor interface
xerial Jun 13, 2015
de6d1f5
Add augumented constructor for ExtensionTypeHeader
xerial Jun 13, 2015
04819a3
Fix test case
xerial Jun 13, 2015
d1807a5
Add ValueType bit mask to improve type check performance
xerial Jun 13, 2015
770f013
Preserve float and double differences
xerial Jun 13, 2015
775379d
Renamed xxxValue that returns primitive type value as toXXX
xerial Jun 13, 2015
301ae10
Remove public scope from interface
xerial Jun 13, 2015
9db3537
Fix compilation error of msgpack-jackson
xerial Jun 13, 2015
c782451
toImmutable -> immutableValue
xerial Jun 15, 2015
ed45331
Remove visitor, ExtensionTypeHeader constructor. Fix exception type o…
xerial Jun 15, 2015
787533c
Remove ValueFactory.newArrayOf
xerial Jun 15, 2015
53557e9
Removed ValueType.bitMask
xerial Jun 15, 2015
9e8c806
Fix test compile error
xerial Jun 15, 2015
33f9ccf
Changed the extension type interface to use byte
xerial Jun 15, 2015
3df8f36
FloatHolder test is no longer necesary
xerial Jun 15, 2015
5289289
Remove RawValue
xerial Jun 15, 2015
4cba605
Fix test case that checks nil value
xerial Jun 15, 2015
c14c87c
Fix test cases and range check of extension types
xerial Jun 15, 2015
f6f9e8f
Fixes test case to use getString to extract raw string value
xerial Jun 15, 2015
e1b8105
Removed obsolete classes
xerial Jun 15, 2015
1d1da11
Moved example codes to test folder
xerial Jun 15, 2015
005edf4
Map.Entry based builder. Add putAll methods
xerial Jun 16, 2015
bef3c55
nil() -> newNil() for method name consisitency
xerial Jun 16, 2015
ca2fb1e
Add comment to ExtensionTypeHeader
xerial Jun 16, 2015
5ba7366
Fix unit test errors
komamitsu Jun 18, 2015
080deb3
Merge pull request #1 from komamitsu/v07-value-impl-rev2-fix-jackson-…
xerial Jun 18, 2015
5ac35d1
Merge pull request #249 from xerial/v07-value-impl-rev2
xerial Jun 19, 2015
b7787d4
removed unnecessary empty lines
frsyuki Jun 23, 2015
27be4d9
removed unused ValueType.toTypeName()
frsyuki Jun 23, 2015
321d64b
added example javadoc on ExtensionTypeHeader constructor
frsyuki Jun 23, 2015
5c51b39
toXXX -> castAsXXX
xerial Jun 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add augumented constructor for ExtensionTypeHeader
  • Loading branch information
@xerial
xerial committed Jun 13, 2015
commit de6d1f5747e05eaa7b26d310a46038ecf1a1fda8
10 changes: 8 additions & 2 deletions msgpack-core/src/main/java/org/msgpack/core/ExtensionTypeHeader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,16 @@ public class ExtensionTypeHeader {
private final byte type;
private final int length;

ExtensionTypeHeader(byte type, int length) {
public ExtensionTypeHeader(byte type, int length) {
checkArgument(length >= 0, String.format("length must be >= 0: %,d", length));
this.length = length;
this.type = type;
this.length = length;
}

public ExtensionTypeHeader(int type, int length) {
checkArgument(Byte.MIN_VALUE <= type && type <= Byte.MAX_VALUE, "Extension type must be within -128 to 127");
this.type = (byte) type;
this.length = length;
}

public byte getType() {
Expand Down