#259: Rename data access methods#265
Merged
xerial merged 5 commits intomsgpack:v07-developfrom Jul 4, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
I'm surprised this works. I would have thought that the toJson would have quoted the string (as ImmutableRawValueImpl does). You actually get a Variable$StringValueAccessor which does't quote the string.
This depends on the output format of toJson however you wrote in the java doc
Do not write code that depends on the resulting json format.
but this depends directly on the output. Should this be using toJson or a method that would be more predictable?
Value#toJson() is expected to return a valid json since its name. Some valid MessagePack values are invalid in JSON such as ExtensionValue, non-string keys in a MapValue, NaN or Infinite.
Member
Fix Value#toJson
Member
Author
|
@frsyuki |
Member
Author
|
@komamitsu Thanks. |
Member
Use RawValue#toString instead of Value#toJson in MessagePackParser
xerial
added a commit
that referenced
this pull request
Jul 4, 2015
#259: Rename data access methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.