Fix MessageBufferU#copyTo called by sliced buffer#283
Conversation
|
@xerial Can you take a look at this pull request? |
komamitsu
changed the title
|
https://travis-ci.org/msgpack/msgpack-java/jobs/87210273 MessageBufferBE can't be used in Travis CI...? |
|
right. MessageBufferBE only works in big endian machine. And initializing MessageBufferU and MessageBufferBE in the code slows down the performance of MessageBuffer test code. |
There was a problem hiding this comment.
MessageBufferU should not be called directly. This changes every MessageBuffer method call to invokeinterface, and deteriorates the performance. TravisCI uses MessageBufferU for jvm6, I think.
There was a problem hiding this comment.
Sorry. For some reason, jvm6 test was turned off. Run test with -Dmsgpack.universal-buffer=true
There was a problem hiding this comment.
https://github.com/msgpack/msgpack-java/blob/v07-develop/.travis.yml#L14
I found we are testing MessageBufferU here, so having a test code that copies data between buffers is sufficient.
There was a problem hiding this comment.
Good to hear. I'll change the test code later. Thanks.
There was a problem hiding this comment.
@xerial Fixed the test code. Can you review it again?
Fix MessageBufferU#copyTo called by sliced buffer
|
Merged. Thanks! |
2 participants
Fix #282